Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131421 / 25.04 / Improve webui professionalism #10764

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Sep 27, 2024

Testing:
Code review.

@undsoft undsoft requested a review from a team as a code owner September 27, 2024 15:45
@undsoft undsoft requested review from bvasilenko and removed request for a team September 27, 2024 15:45
@bugclerk bugclerk changed the title NAS-131421: Improve webui professionalism NAS-131421 / 25.04 / Improve webui professionalism Sep 27, 2024
@bugclerk
Copy link
Contributor

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶

@undsoft undsoft enabled auto-merge (squash) September 27, 2024 16:24
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.29%. Comparing base (3c7fecd) to head (1743eb2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10764   +/-   ##
=======================================
  Coverage   80.29%   80.29%           
=======================================
  Files        1571     1571           
  Lines       51714    51714           
  Branches     5840     5840           
=======================================
  Hits        41522    41522           
  Misses      10192    10192           
Flag Coverage Δ
80.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit 899fbef into master Sep 27, 2024
7 checks passed
@undsoft undsoft deleted the NAS-131421 branch September 27, 2024 16:26
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants